D25301: Move createUDSEntry from file.cpp to file_unix.cpp

dfaure added a comment. Fixed in commit bc2b22d2fdf5b4f932 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25301 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

dfaure added a comment. Fails to build here file_unix.cpp:384:9: error: ‘appendACLAtoms’ was not declared in this scope I'll investigate. You might want to install the necessary libs for the ACL code to be enabled on your system. REPOSITORY R241 KIO REVISION DETAIL https://phab

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c5009b8b4ab9: Move createUDSEntry from file.cpp to file_unix.cpp (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25301?vs=78159&id=78207 REVISION D

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

dfaure accepted this revision. REPOSITORY R241 KIO BRANCH arcpatch-D25301 REVISION DETAIL https://phabricator.kde.org/D25301 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

meven updated this revision to Diff 78159. meven marked 3 inline comments as done. meven added a comment. Add 3 missing static REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25301?vs=78141&id=78159 BRANCH arcpatch-D25301 REVISION DETAIL https://phabricato

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS > file_unix.cpp:147 > + > +QString getUserName(KUserId uid) > +{ static > file_unix.cpp:164 > + > +QString getGroupName(KGroupId gid) > +{ static > file_unix.cpp:248 > + > +bool createUDSEntry(const QString &filename

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

meven updated this revision to Diff 78141. meven added a comment. Rebase on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25301?vs=69731&id=78141 BRANCH arcpatch-D25301 REVISION DETAIL https://phabricator.kde.org/D25301 AFFECTED FILES src/iosla

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

meven added a comment. I have currently a couple of patches touching the same lines, so I will postpone this land after to save me some rebasing time. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25301 To: meven, #frameworks, dfaure Cc: kde-framework

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Well spotted. Sorry for the delay in my review. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25301 To: meven, #frameworks, dfaure Cc: kde-fram

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

meven created this revision. meven added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY This was a unix only function in the shared file protocol cpp This has not been