dfaure requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D25302
To: sandsmark, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,
bruns
dfaure added inline comments.
INLINE COMMENTS
> karchive.cpp:986
> +// link target or be non-relative
> +if (QFile::exists(linkName) && linkName !=
> curEntry->symLinkTarget()) {
> +QFile::remove(linkName);
This is comparing the name of the sy
sandsmark added a comment.
I've asked hhartz to create a test file, I'll ping him again on monday when
I'm back at work.
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D25302
To: sandsmark, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Looks ok, although a unittest would have been even better.
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D25302
To: sandsmark, dfaure
Cc: dfaure, kde-frameworks-
sandsmark created this revision.
sandsmark added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
sandsmark requested review of this revision.
REVISION SUMMARY
When receiving a symlink, QFile::link will refuse in
