D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux abandoned this revision. cgiboudeaux added a comment. I applied the patch to our openexr package instead. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25304 To: cgiboudeaux Cc: arojas, kde-frameworks-devel, kde-buildsystem, LeGast00n,

D25304: Fix the OpenEXR >= 2.4 detection

arojas added a comment. > The pkgconfig file disagrees: > it contains `libsuffix=-2_4` and later `Libs: -L${libdir} -lIlmImf${libsuffix}` > For me, that library name is correct I didn't say that the suffixed .so shouldn't exist. They are *both* supposed to be installed: the

D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux added a comment. In D25304#562561 , @arojas wrote: > > I don't see how that commit is related. > > openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so > > > > This is expected afaics. > > No, it's not. That line

D25304: Fix the OpenEXR >= 2.4 detection

arojas added a comment. > I don't see how that commit is related. > openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so > > This is expected afaics. No, it's not. That line in openexr is supposed to link libXXX-2_4.so (${verlibname}) to libXXX.so (${baselibname}) but it

D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux added a comment. In D25304#562553 , @arojas wrote: > This is a bug in openexr. It does actually try to install the unsuffixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem

D25304: Fix the OpenEXR >= 2.4 detection

arojas added a comment. This is a bug in openexr. It does actually try to install the unprefixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem instead of doing so inside DESTDIR as it should. It is fixed in

D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux added a comment. Note: openEXR >= 2.4 provides CMake configuration modules (OpenEXRConfig.cmake and IlmBaseConfig.cmake). We could also look for those and use the current code as a fallback if the modules can't be found REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. cgiboudeaux requested review of this revision. REVISION SUMMARY Newer OpenEXR versions add a suffix to the libraries file names. ECM can now