D25340: Added background colors to active and inactive icon view

This revision was automatically updated to reflect the committed changes. Closed by commit R242:7e52c869de2d: Added background colors to active and inactive icon view (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25340: Added background colors to active and inactive icon view

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D25340 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin,

D25340: Added background colors to active and inactive icon view

ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

ndavis updated this revision to Diff 71092. ndavis added a comment. - change minimized bg opacity to 8% REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=71084=71092 BRANCH arcpatch-D25340 (branched from master) REVISION DETAIL

D25340: Added background colors to active and inactive icon view

ngraham added a comment. This feels so close to perfection! But now it feels like the minimized bg is too subtle, maybe. I wonder if 0.08 opacity for minimized tasks might help. Or maybe I'm just torturing this poor patch to death... REPOSITORY R242 Plasma Framework (Library) REVISION

D25340: Added background colors to active and inactive icon view

ndavis updated this revision to Diff 71084. ndavis added a comment. - Change normal bg to 15% opacity - Change minimized bg to 5% opacity REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=71050=71084 BRANCH arcpatch-D25340

D25340: Added background colors to active and inactive icon view

ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

ndavis commandeered this revision. ndavis edited reviewers, added: niccolove; removed: ndavis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel,

D25340: Added background colors to active and inactive icon view

niccolove added a comment. In D25340#573672 , @ndavis wrote: > @niccolove Do you mind if I commandeer this? I know dealing with these kinds of issues can be super annoying and I'm already used to it. Feel free to do that :-) REPOSITORY

D25340: Added background colors to active and inactive icon view

ndavis added a comment. @niccolove Do you mind if I commandeer this? I know dealing with these kinds of issues can be super annoying and I'm already used to it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham,

D25340: Added background colors to active and inactive icon view

ndavis added a comment. It's still going to be a PITA with manual editing. Maybe there's a way to automate it with `awk`, but I don't know that tool well enough. This should at least make the deleting part easier: `sed --follow-symlinks -i 's/style="opacity:0.05"//' tasks.svg` Do this

D25340: Added background colors to active and inactive icon view

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham, ndavis Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel,

D25340: Added background colors to active and inactive icon view

ndavis added a comment. Oh wait, here's the problem INLINE COMMENTS > tasks.svg:3206 > + transform="matrix(-1 0 0 -1 36 134)" > + opacity=".16" > + style="opacity:0.05"> Starts here Conflicting opacity values. Set `opacity="0.05"` and delete the conflicting

D25340: Added background colors to active and inactive icon view

ndavis added a comment. In D25340#573654 , @ngraham wrote: > Hmm, I'm not seeing any change, and the difference between open and maximized items is still too subtle IMO: F7804140: Screenshot_20191207_093912.PNG

D25340: Added background colors to active and inactive icon view

ngraham added a comment. Hmm, I'm not seeing any change, and the difference between open and maximized items is still too subtle IMO: F7804140: Screenshot_20191207_093912.PNG If the background is a different color/opacity, I can't tell. REPOSITORY

D25340: Added background colors to active and inactive icon view

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH backrgound-color-iconviewer (branched from master) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham, ndavis Cc: filipf,

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 71050. niccolove added a comment. Reset tabbar to master REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=71048=71050 BRANCH backrgound-color-iconviewer (branched from master) REVISION

D25340: Added background colors to active and inactive icon view

niccolove added a comment. In D25340#573594 , @ndavis wrote: > Wait, is a change to tabbar.svg supposed to be in this diff? Nope, I must have messed up the different arc features. Sorry. REPOSITORY R242 Plasma Framework (Library)

D25340: Added background colors to active and inactive icon view

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Wait, is a change to tabbar.svg supposed to be in this diff? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove,

D25340: Added background colors to active and inactive icon view

ndavis accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH backrgound-color-iconviewer (branched from master) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham, ndavis Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel,

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 71048. niccolove added a comment. Changed inactive to 5% REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=70207=71048 BRANCH backrgound-color-iconviewer (branched from master) REVISION

D25340: Added background colors to active and inactive icon view

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I guess I should change my status to accepted given that I think this is good enough and already an improvement. But I think we can do even better, @niccolove. :) REPOSITORY R242

D25340: Added background colors to active and inactive icon view

filipf added a comment. In D25340#563400 , @ndavis wrote: > This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which isn't in git master. Do I actually need that commit for this patch to work? A similar issue still

D25340: Added background colors to active and inactive icon view

ngraham added a comment. Can we push this forward? I just triaged a bunch of bugs and found that https://bugs.kde.org/show_bug.cgi?id=370465 now has five duplicates. There seems to be quite a bit of demand for this. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25340: Added background colors to active and inactive icon view

ndavis added a comment. In that case, maybe 5% opacity for minimized? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

ngraham added a comment. I can accept this as-is, but I think I'd still prefer the background color of minimized apps/windows to be a bit lighter or more transparent. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg,

D25340: Added background colors to active and inactive icon view

niccolove added a comment. > Might be too subtle, maybe more opacity would be needed This should have a 13% vs 23% opacity, what do you think? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham Cc: manueljlin,

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 70207. niccolove added a comment. Changed opacity of inactive vs non-visible application background color REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=69882=70207 BRANCH

D25340: Added background colors to active and inactive icon view

ngraham added a comment. In D25340#563913 , @ndavis wrote: > F7769041: Screenshot_20191117_203818.png > 15% Inactive BG opacity > 10% Minimized BG opacity Might be too subtle, maybe more

D25340: Added background colors to active and inactive icon view

manueljlin added a comment. Please, consider using 3px highlight so tabs don't look like this. This one is from the kickoff task but it would also happen in Audio Volume. F7771606: IMG_20191119_151319.jpg REPOSITORY R242 Plasma Framework (Library)

D25340: Added background colors to active and inactive icon view

ndavis added a comment. F7769041: Screenshot_20191117_203818.png 15% Inactive BG opacity 10% Minimized BG opacity REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham Cc:

D25340: Added background colors to active and inactive icon view

ndavis added a comment. In D25340#563908 , @ngraham wrote: > Decreasing the opacity of the icon itself? Maybe that could work. Not the icon, the background. > A pet peeve I have with the status quo is that minimized apps/windows have

D25340: Added background colors to active and inactive icon view

ngraham added a comment. Decreasing the opacity of the icon itself? Maybe that could work. A pet peeve I have with the status quo is that minimized apps/windows have greater visual prominence than other ones, which seems backwards. This patch generally fixes that (especially for the

D25340: Added background colors to active and inactive icon view

ndavis added a comment. In D25340#563783 , @ngraham wrote: > I don't hate the current state, let me note. It's just not what I expected, and I feel like I would need to get used to it rather than immediately falling in love with it.

D25340: Added background colors to active and inactive icon view

niccolove added a comment. Now that we got back the 3px line, I would say that it is recognizable. I like the idea of having the background and reinforcing the idea that line=visible. But it's such a minor change that I would be okay with any option really. F7768659:

D25340: Added background colors to active and inactive icon view

ngraham added a comment. I don't hate the current state, let me note. It's just not what I expected, and I feel like I would need to get used to it rather than immediately falling in love with it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25340: Added background colors to active and inactive icon view

ngraham added a comment. I'm not 100% sure how I feel about the change to use the same background color for "open" and "minimized" states and distinguish the two entirely with the presence or absence of a gray line. It feels very subtle, almost too much so. I preferred it when the open and

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 69882. niccolove added a comment. Tweaked colors of icon view backgrounds REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=69880=69882 BRANCH backrgound-color-iconviewer (branched from

D25340: Added background colors to active and inactive icon view

niccolove added a comment. In D25340#563593 , @ndavis wrote: > Here's a cleaned up version of the file with the changes Nate and I requested: F7767647: tasks.svg Oh sorry, I missed this. I'll use

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 69880. niccolove added a comment. Changed 2px lines to 3px REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=69851=69880 BRANCH backrgound-color-iconviewer (branched from master) REVISION

D25340: Added background colors to active and inactive icon view

ndavis added a comment. I wonder if the Light gray line on the inactive mode should be a little brighter (up to 35% opacity) or if the background for inactive and minimized should be a little darker (down to 15% opacity) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25340: Added background colors to active and inactive icon view

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

ndavis added a comment. Here's a cleaned up version of the file with the changes Nate and I requested: F7767647: tasks.svg F7767649: Screenshot_20191117_005703.png REPOSITORY R242 Plasma Framework (Library)

D25340: Added background colors to active and inactive icon view

ndavis added a comment. Unfortunately, InactiveText doesn't work and neither does DisabledText. I might need to change whatever library handles stylesheets for plasmashell. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove,

D25340: Added background colors to active and inactive icon view

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Also, according to the title, the line thickness changes are unrelated, so they shouldn't even be included here at all. Let's make this patch only about adding/changing

D25340: Added background colors to active and inactive icon view

ngraham added a comment. I like the background changes here and I think it makes logical sense to have a progression of changing background colors to indicate the status. However I'm not a huge fan of reducing the active indicator to just 2px. It's now so small that it becomes kind of

D25340: Added background colors to active and inactive icon view

ndavis added a comment. In D25340#563388 , @niccolove wrote: > > @ndavis said: > > Here's what I think: > > > > - The line should indicate that the app is opened, the window is not minimized and the window is focused (opaque blue) or

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 69851. niccolove added a comment. Added background colors to active and inactive icon view REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=69849=69851 BRANCH backrgound-color-iconviewer

D25340: Added background colors to active and inactive icon view

niccolove added a comment. In D25340#563400 , @ndavis wrote: > This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which isn't in git master. Do I actually need that commit for this patch to work? No. My bad. Let me

D25340: Added background colors to active and inactive icon view

ndavis added a comment. This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which isn't in git master. Do I actually need that commit for this patch to work? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove,

D25340: Added background colors to active and inactive icon view

niccolove added a subscriber: ndavis. niccolove added a comment. > @ndavis said: > Here's what I think: > > - The line should indicate that the app is opened, the window is not minimized and the window is focused (opaque blue) or inactive (opaque gray) > - The background should

D25340: Added background colors to active and inactive icon view

niccolove edited the test plan for this revision. niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Added: - Light blue color for active window - Light gray color for inactive but not minimized window