D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

2019-11-27 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:cee9d9642735: KateModeManager::updateFileType(): validate modes and reload menu of the status… (authored by nibags, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

2019-11-27 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think that is nicer, not yet-an-other global hash ;=) Thanks! REPOSITORY R39 KTextEditor BRANCH verify-katefiletypes REVISION DETAIL https://phabricator.kde.org/D25390

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

2019-11-26 Thread Nibaldo González
nibags added a comment. Now the object KateModeMenuList is obtained from the object KateStatusBar. I don't know if you prefer this way REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25390 To: nibags, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel,

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

2019-11-26 Thread Nibaldo González
nibags updated this revision to Diff 70392. nibags added a comment. - Get the KateMenuList objects using KateGlobal REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25390?vs=69971=70392 BRANCH verify-katefiletypes REVISION DETAIL

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

2019-11-26 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I like the overall effect, but I don't like the new static registry. We already have some registry in KateGlobal for all views, we would just need to allow to access the

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

2019-11-18 Thread Nibaldo González
nibags edited the summary of this revision. nibags added reviewers: KTextEditor, cullmann, dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25390 To: nibags, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson,

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

2019-11-18 Thread Nibaldo González
nibags updated this revision to Diff 69971. nibags added a comment. - Fix format REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25390?vs=69970=69971 BRANCH verify-katefiletypes REVISION DETAIL https://phabricator.kde.org/D25390 AFFECTED FILES

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

2019-11-18 Thread Nibaldo González
nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R39 KTextEditor BRANCH verify-katefiletypes REVISION DETAIL https://phabricator.kde.org/D25390