D25515: Only extract lyrics when the plain text flag is set

2020-04-19 Thread Alexander Stippich
astippich abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25515 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, s

D25515: Only extract lyrics when the plain text flag is set

2020-03-19 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems sane. REPOSITORY R286 KFileMetaData BRANCH lyricsExtraction REVISION DETAIL https://phabricator.kde.org/D25515 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-framew

D25515: Only extract lyrics when the plain text flag is set

2019-11-27 Thread Alexander Stippich
astippich added a comment. For baloo-widgets, the display of the lyrics tag is disabled anyways. Displaying a large chunk of text does not really look good in the information panel... REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25515 To: astippich, #baloo

D25515: Only extract lyrics when the plain text flag is set

2019-11-26 Thread Stefan Brüns
bruns added a comment. The dolphin temp extractor uses `KFileMetaData::ExtractionResult::ExtractMetaData` explicitly. Though in general I agree (and "PlainText" should be better named "FullText"). REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25515 To:

D25515: Only extract lyrics when the plain text flag is set

2019-11-25 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: Baloo, bruns, mgallien, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY One can argue that lyrics are not really metadata,