D25516: Remove unrequired private declarations for taglibextractor

2019-12-15 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:f2fea112: Remove unrequired private declarations for 
taglibextractor (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25516?vs=70398&id=71620

REVISION DETAIL
  https://phabricator.kde.org/D25516

AFFECTED FILES
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h

To: astippich, #baloo, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25516: Remove unrequired private declarations for taglibextractor

2019-12-12 Thread Stefan Brüns 
bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  cleanupTagLib

REVISION DETAIL
  https://phabricator.kde.org/D25516

To: astippich, #baloo, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25516: Remove unrequired private declarations for taglibextractor

2019-11-27 Thread Alexander Stippich 
astippich updated this revision to Diff 70398.
astippich added a comment.


  - put all helper functions into anonymous namespace

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25516?vs=70283&id=70398

BRANCH
  cleanupTagLib

REVISION DETAIL
  https://phabricator.kde.org/D25516

AFFECTED FILES
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h

To: astippich, #baloo, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25516: Remove unrequired private declarations for taglibextractor

2019-11-27 Thread Alexander Stippich 
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibextractor.cpp:105
> This puts `readGenericProperties(...)` with external linkage in the global 
> namespace.
> 
> Put the private helpers in an anonymous namespace (and also include 
> `extractAudioProperties(...)` in it).

Urgh, that was the plan actually. I could swear I've done that.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25516

To: astippich, #baloo, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25516: Remove unrequired private declarations for taglibextractor

2019-11-26 Thread Stefan Brüns 
bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> taglibextractor.cpp:105
>  
> -void TagLibExtractor::readGenericProperties(const TagLib::PropertyMap 
> &savedProperties, ExtractionResult* result)
> +void readGenericProperties(const TagLib::PropertyMap &savedProperties, 
> ExtractionResult* result)
>  {

This puts `readGenericProperties(...)` with external linkage in the global 
namespace.

Put the private helpers in an anonymous namespace (and also include 
`extractAudioProperties(...)` in it).

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25516

To: astippich, #baloo, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25516: Remove unrequired private declarations for taglibextractor

2019-11-25 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  cleanupTagLib

REVISION DETAIL
  https://phabricator.kde.org/D25516

To: astippich, #baloo, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25516: Remove unrequired private declarations for taglibextractor

2019-11-25 Thread Alexander Stippich 
astippich added a dependent revision: D25518: Extract front cover in the taglib 
extractor.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25516

To: astippich, #baloo, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25516: Remove unrequired private declarations for taglibextractor

2019-11-25 Thread Alexander Stippich 
astippich created this revision.
astippich added reviewers: Baloo, bruns, ngraham, mgallien.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  They do not need to be declared in the header

REPOSITORY
  R286 KFileMetaData

BRANCH
  cleanupTagLib

REVISION DETAIL
  https://phabricator.kde.org/D25516

AFFECTED FILES
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h

To: astippich, #baloo, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams