D25517: Add an option to extract image data and add front cover property

astippich abandoned this revision. astippich added a comment. Okay, since there seems to be no interest at all as even a short reply is not given, I am done here REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngra

D25517: Add an option to extract image data and add front cover property

astippich added a comment. Due to the recent circumstances I will probably not implement the support in Elisa, so I won't land this unless @bruns explicitly is okay with it (I still think this is an improvement over the status quo). REPOSITORY R286 KFileMetaData REVISION DETAIL https://

D25517: Add an option to extract image data and add front cover property

astippich added a comment. Since I got one accept and no other response, I will merge on the weekend REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n

D25517: Add an option to extract image data and add front cover property

astippich updated this revision to Diff 77954. astippich added a comment. - fix label comment - tweaks - rename flag to ImageData - adress review comments - udpate since tag - update since tag REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D25517: Add an option to extract image data and add front cover property

astippich added a comment. ping @bruns this has now been open and unanswered for month! Same for the dependent patches REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77

D25517: Add an option to extract image data and add front cover property

ngraham accepted this revision. ngraham added a comment. I agree, let's get this in now and refactor it later. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs,

D25517: Add an option to extract image data and add front cover property

astippich added a comment. Ping! At least a reply would be nice REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson

D25517: Add an option to extract image data and add front cover property

astippich added a comment. Where are we with this? @bruns are you accepting the proposed solution or do you reject it completely? I think it is at least way better than the current solution and maintains current API. A larger refactoring could be done for KF6 REPOSITORY R286 KFileMetaD

D25517: Add an option to extract image data and add front cover property

astippich updated this revision to Diff 75306. astippich added a comment. - udpate since tag REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25517?vs=73097&id=75306 BRANCH binaryData REVISION DETAIL https://phabricator.kde.org/D25517 AFFECTED FI

D25517: Add an option to extract image data and add front cover property

astippich added a comment. friendly ping for the series REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov,

D25517: Add an option to extract image data and add front cover property

astippich marked 2 inline comments as done. astippich added a comment. In D25517#588029 , @bruns wrote: > The problem is the extractor serves two different use cases: > > - retrieval for searching/caching properties > - on-demand extraction

D25517: Add an option to extract image data and add front cover property

astippich updated this revision to Diff 73097. astippich added a comment. - adress review comments REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25517?vs=71623&id=73097 BRANCH binaryData REVISION DETAIL https://phabricator.kde.org/D25517 AFFEC

D25517: Add an option to extract image data and add front cover property

bruns added a comment. The problem is the extractor serves two different use cases: - retrieval for searching/caching properties - on-demand extraction Baloo falls into the first category. It is only interested in properties which can be queried/compared in a meaningful way. Even

D25517: Add an option to extract image data and add front cover property

ngraham added a comment. In D25517#587957 , @astippich wrote: > I also fear that it may not be clear to distinguish between "simple" and "complex" properties and that users of the API would expect that every property works for the setExtraPrope

D25517: Add an option to extract image data and add front cover property

astippich added a comment. In D25517#587776 , @bruns wrote: > I have thought about this and have come to the conclusion this is not really future proof. > > The `Property::FrontCover` is IMHO fine, i.e. the changes to `propertyinfo.cpp` and

D25517: Add an option to extract image data and add front cover property

bruns added a comment. I have thought about this and have come to the conclusion this is not really future proof. The `Property::FrontCover` is IMHO fine, i.e. the changes to `propertyinfo.cpp` and `properties.h` could go in as is. The request of additional properties should be done

D25517: Add an option to extract image data and add front cover property

ngraham added a comment. LGTM REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoo

D25517: Add an option to extract image data and add front cover property

astippich added a comment. friendly ping! I would like to continue work on this. Is the new name better? If so, I will rebase follow-up patches REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-framew

D25517: Add an option to extract image data and add front cover property

astippich retitled this revision from "Add an option to extract binary data and add front cover property" to "Add an option to extract image data and add front cover property". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mg