D25533: Deprecate KFileWidget::toolBar

2019-12-15 Thread Nicolas Fella 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6973d4b26501: Deprecate KFileWidget::toolBar (authored by 
nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25533?vs=70622=71631#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25533?vs=70622=71631

REVISION DETAIL
  https://phabricator.kde.org/D25533

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25533: Deprecate KFileWidget::toolBar

2019-12-02 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  This patch itself is still correct though, of course.

REPOSITORY
  R241 KIO

BRANCH
  ktoolbar

REVISION DETAIL
  https://phabricator.kde.org/D25533

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25533: Deprecate KFileWidget::toolBar

2019-11-30 Thread David Faure 
dfaure added a comment.


  I started a kdesrc-build with the method removed, and found that 
KFileDialog::toolBar (in kdelibs4support) uses it, so it needs a matching #if 
in case EXCLUDE_DEPRECATED_BEFORE_AND_AT.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25533

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25533: Deprecate KFileWidget::toolBar

2019-11-30 Thread Nicolas Fella 
nicolasfella updated this revision to Diff 70622.
nicolasfella added a comment.


  - Adjust version

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25533?vs=70317=70622

BRANCH
  ktoolbar

REVISION DETAIL
  https://phabricator.kde.org/D25533

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilewidget.h

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25533: Deprecate KFileWidget::toolBar

2019-11-27 Thread David Faure 
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  5.65 isn't released yet, you can use 5.65 as deprecation version here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25533

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25533: Deprecate KFileWidget::toolBar

2019-11-25 Thread Nicolas Fella 
nicolasfella added a task: T12206: Port KFileWidget away from KToolBar.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25533

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25533: Deprecate KFileWidget::toolBar

2019-11-25 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  It leaks KToolBar from KXmlGui into the public API. I did not find any code 
using it

TEST PLAN
  builds

REPOSITORY
  R241 KIO

BRANCH
  ktoolbar

REVISION DETAIL
  https://phabricator.kde.org/D25533

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilewidget.h

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns