This revision was automatically updated to reflect the committed changes.
Closed by commit R150:423c75cc12c3: Port to json metadata (authored by
nicolasfella).
REPOSITORY
R150 KDE Telepathy KDE Daemon Module
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25630?vs=70698=70869
akulichalexandr accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R150 KDE Telepathy KDE Daemon Module
BRANCH
json
REVISION DETAIL
https://phabricator.kde.org/D25630
To: nicolasfella, #frameworks, #kde_telepathy, akulichalexandr
Cc: akulichalexandr,
nicolasfella updated this revision to Diff 70698.
nicolasfella added a comment.
- Use kcoreaddons_desktop_to_json
REPOSITORY
R150 KDE Telepathy KDE Daemon Module
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25630?vs=70623=70698
BRANCH
json
REVISION DETAIL
akulichalexandr added a comment.
Hi!
Thank you for taking this up.
Would you mind to use the same approach as in plasma-workspace? In case of
your changes we'll lose the translations, but with desktop_to_json we won't
have such a problem.
ltoscano added inline comments.
INLINE COMMENTS
> ktp_integration_module.json:3
> +"KPlugin": {
> +"Description": "Module providing deeper integration of Instant
> Messaging with KDE.",
> +"Name": "Telepathy Integration Module",
I can't comment on the rest of the reivew,
nicolasfella added a task: T11919: Port KDED modules from .desktop files to
JSON metadata.
REPOSITORY
R150 KDE Telepathy KDE Daemon Module
REVISION DETAIL
https://phabricator.kde.org/D25630
To: nicolasfella, #frameworks
nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
nicolasfella requested review of this revision.
REPOSITORY
R150 KDE Telepathy KDE Daemon Module
BRANCH
json
REVISION DETAIL
https://phabricator.kde.org/D25630
AFFECTED FILES
CMakeLists.txt
nicolasfella added a reviewer: KDE Telepathy.
REPOSITORY
R150 KDE Telepathy KDE Daemon Module
REVISION DETAIL
https://phabricator.kde.org/D25630
To: nicolasfella, #frameworks, #kde_telepathy
