D25671: Fix git builds against Qt 5.14
This revision was automatically updated to reflect the committed changes. Closed by commit R129:771ed0c4f8c2: Fix git builds against Qt 5.14 (authored by apol). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25671?vs=70706=70734 REVISION DETAIL https://phabricator.kde.org/D25671 AFFECTED FILES CMakeLists.txt To: apol, #frameworks, vkrause Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25671: Fix git builds against Qt 5.14
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R129 Window Decoration Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D25671 To: apol, #frameworks, vkrause Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25671: Fix git builds against Qt 5.14
apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It's not really acceptable to just error on everything since some of the solutions (like in this case) might not be retrocompatible. The error was: kdecoration/src/decoration.cpp:386:37: error: no member named 'posF' in 'QWheelEvent' TEST PLAN Builds now REPOSITORY R129 Window Decoration Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D25671 AFFECTED FILES CMakeLists.txt To: apol, #frameworks Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
