kdudka added a comment.
There is a fix-up for this change waiting to be merged:
https://invent.kde.org/frameworks/kconfig/-/merge_requests/134
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D25833
To: davidedmundson, broulik
Cc: kdudka, arojas, broulik,
arojas added a comment.
This breaks compilation of python bindings:
sip:
/build/kconfig/src/build/src/core/sip/PyKF5/KConfigCore/kconfigwatcher.sip:17:
::KConfigWatcher::config() unsupported function return type - provide
%MethodCode and a C++ signature
REPOSITORY
R237 KConfig
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:7ab8275bdb56: Expose getter to KConfigWatchers
config (authored by davidedmundson).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25833?vs=71159=71171
REVISION
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kconfigwatcher.h:56
> + * Returns the config being watched
> + * @since 5.65
> + */
5.66 - tagging for 5.65 was last Sunday
REPOSITORY
R237 KConfig
davidedmundson added a dependent revision: D25834: [effects/startupfeedback]
Port to KConfigWatcher.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D25833
To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
It can help save users having to member variables for the config and the
watcher.
REPOSITORY
R237
