This revision was automatically updated to reflect the committed changes.
Closed by commit R320:6f1b8a6c61d8: Fix decrement index and not iterator as
discussed with David (authored by mlaurent).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25902?vs=71322&
dfaure accepted this revision.
dfaure added a comment.
We can thank Qt for deprecating QHash::iterator::operator-- which allowed
Laurent to catch this :-)
REPOSITORY
R320 KIO Extras
BRANCH
fix_kioslave_notifier (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25902
anthonyfieroni accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R320 KIO Extras
BRANCH
fix_kioslave_notifier (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25902
To: mlaurent, dfaure, anthonyfieroni
Cc: anthonyfieroni, kde-frameworks
mlaurent added a comment.
Ping ?:)
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D25902
To: mlaurent, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, kfm-devel, pberestov, iasensio,
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,
mev
mlaurent updated this revision to Diff 71322.
mlaurent added a comment.
Fix other code
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25902?vs=71312&id=71322
BRANCH
fix_kioslave_notifier (branched from master)
REVISION DETAIL
https://phabricator.kd
anthonyfieroni added inline comments.
INLINE COMMENTS
> kioslavenotifier.cpp:114
> else
> *it++;
> }
Same here
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D25902
To: mlaurent, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, kfm-devel, pberestov,
mlaurent created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
Fix decrement index and not iterator
REPOSITORY
R320 KIO Extras
BRANCH
fix_kioslave_notifier (
mlaurent added a reviewer: dfaure.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D25902
To: mlaurent, dfaure
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh,
spooru
