D25926: [PC3] Only show progress bar indicator when the ends won't overlap
This revision was automatically updated to reflect the committed changes. Closed by commit R242:e91ba953eafb: [PC3] Only show progress bar indicator when the ends wont overlap (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25926?vs=71369=71425 REVISION DETAIL https://phabricator.kde.org/D25926 AFFECTED FILES src/declarativeimports/plasmacomponents3/ProgressBar.qml To: davidedmundson, #plasma, filipf Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25926: [PC3] Only show progress bar indicator when the ends won't overlap
filipf accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25926 To: davidedmundson, #plasma, filipf Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25926: [PC3] Only show progress bar indicator when the ends won't overlap
davidedmundson added a reviewer: filipf. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25926 To: davidedmundson, #plasma, filipf Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25926: [PC3] Only show progress bar indicator when the ends won't overlap
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY If the width is smaller than LeftMargin + Right Margin the two ends overlap and it looks super weird TEST PLAN Progressbar manual unit test looks sane REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25926 AFFECTED FILES src/declarativeimports/plasmacomponents3/ProgressBar.qml To: davidedmundson, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
