This revision was automatically updated to reflect the committed changes.
Closed by commit R240:7c84be59f686: Support PyQt5 compiled with SIP 5 (authored
by arojas).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25972?vs=71563=71574
REVISION
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D25972
To: arojas, bruns, dfaure, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,
michaelh,
arojas marked an inline comment as done.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D25972
To: arojas, bruns, dfaure
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,
michaelh, ngraham, bruns
arojas updated this revision to Diff 71563.
arojas added a comment.
Use HINTS
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25972?vs=71481=71563
REVISION DETAIL
https://phabricator.kde.org/D25972
AFFECTED FILES
apol added a comment.
LGTM overall
INLINE COMMENTS
> FindPythonModuleGeneration.cmake:312
>NAMES QtCoremod.sip
> + PATHS ${KDE_INSTALL_PYTHON3DIR}/PyQt5/bindings/QtCore
>PATH_SUFFIXES share/sip/PyQt5/QtCore
Should probably be HINTS.
REPOSITORY
R240 Extra CMake Modules
REVISION
arojas created this revision.
arojas added reviewers: bruns, dfaure.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
arojas requested review of this revision.
REVISION SUMMARY
When PyQt5 is compiled with SIP 5, the sip files are
