dfaure added a comment.
I see, thanks for the clarification.
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D25975
To: dfaure, apol, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
cgiboudeaux added inline comments.
INLINE COMMENTS
> dfaure wrote in kservicefactory.cpp:6-7
> The reason is Waldo Bastian, who agreed to 2-or-3 but not to 2+
>
> waba ( 17 LOC):
> 7ee6ea605e,ec1dc9339f,307504885e,764b51a72c,f1d9d663e6,010677452e,79787d4962,5dcce58a32,0ef36944f8
>
>
> He
dfaure closed this revision.
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D25975
To: dfaure, apol, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R309 KService
BRANCH
relicense
REVISION DETAIL
https://phabricator.kde.org/D25975
To: dfaure, apol, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
dfaure updated this revision to Diff 71501.
dfaure added a comment.
Make kservicefactory.cpp 2-or-3-with-eV-clause
REPOSITORY
R309 KService
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25975?vs=71499=71501
BRANCH
relicense
REVISION DETAIL
dfaure added inline comments.
INLINE COMMENTS
> cgiboudeaux wrote in kservicefactory.cpp:6-7
> What's the reason for only changing this one to LGPL2 only or LGPL3 only
> (without the eV clause)?
The reason is Waldo Bastian, who agreed to 2-or-3 but not to 2+
waba ( 17 LOC):
cgiboudeaux added inline comments.
INLINE COMMENTS
> kservicefactory.cpp:6-7
> * modify it under the terms of the GNU Library General Public
> - * License version 2 as published by the Free Software Foundation;
> + * License as published by the Free Software Foundation; either
> + *
dfaure added a comment.
Indeed, I never think about those COPYING files. In fact this is something
that is definitely inconsistent in most of the frameworks right now...
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D25975
To: dfaure, apol
Cc: cgiboudeaux,
dfaure updated this revision to Diff 71499.
dfaure added a comment.
Add COPYING.LGPL-2 and COPYING.LGPL-3
REPOSITORY
R309 KService
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25975?vs=71487=71499
BRANCH
relicense
REVISION DETAIL
https://phabricator.kde.org/D25975
cgiboudeaux added a comment.
Note that you don't have a LGPL-2.0-or-later COPYING file in this repo
(there's also no LGPL-2.0-only).
COPYING.LIB contains the LGPL-2.1 license which is used by one file in the
tests/ folder
REPOSITORY
R309 KService
REVISION DETAIL
dfaure created this revision.
dfaure added a reviewer: apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
Unfortunately this doesn't cover all LGPLv2-only files.
I cannot find a way to contact
11 matches
Mail list logo
