D26017: [KKeySequenceWidget] Work around Meta modifier behavior

2020-04-09 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:577e8cddde7d: [KKeySequenceWidget] Work around Meta 
modifier behavior (authored by broulik).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26017?vs=71597&id=79708

REVISION DETAIL
  https://phabricator.kde.org/D26017

AFFECTED FILES
  src/kkeysequencewidget.cpp

To: broulik, #frameworks, davidedmundson, ahartmetz
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D26017: [KKeySequenceWidget] Work around Meta modifier behavior

2019-12-20 Thread Kai Uwe Broulik
broulik added a reviewer: ahartmetz.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D26017

To: broulik, #frameworks, davidedmundson, ahartmetz
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26017: [KKeySequenceWidget] Work around Meta modifier behavior

2019-12-15 Thread David Edmundson
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D26017

To: broulik, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26017: [KKeySequenceWidget] Work around Meta modifier behavior

2019-12-15 Thread Kai Uwe Broulik
broulik created this revision.
broulik added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When I press my Meta key, I get a `Key_Super_L` *without* a Meta key 
confusing the rest of the modifier handling in this class.
  To work around this, explicitly set `MetaModifier` when the key is pressed 
and remove it

TEST PLAN
  - I can now press Meta and it is handled immediately like Alt and Shift

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D26017

AFFECTED FILES
  src/kkeysequencewidget.cpp

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns