This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ee3176ce5641: Expose KConfig settings to allow
registration in KCM Notification (authored by crossi).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
ervin accepted this revision.
ervin added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> broulik wrote in settings.cpp:173
> I still want to be able to specify what `config` (constructor argument) to
> use for autotests
After discussing with kai, let's mark
broulik added a comment.
Other than the seemingly missing `config`, looks good
INLINE COMMENTS
> settings.cpp:173
> -if (!s_settingsInited) {
> -DoNotDisturbSettings::instance(config);
> -NotificationSettings::instance(config);
I still want to be able to specify what
crossi updated this revision to Diff 74023.
crossi added a comment.
Remove unneeded forward declaration
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26047?vs=74021=74023
REVISION DETAIL
https://phabricator.kde.org/D26047
AFFECTED FILES
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.
I like it, just an unwanted change to clean up still. @broulik what say you?
INLINE COMMENTS
> settings.h:33
>
> +class KCoreConfigSkeleton;
> +
This change isn't needed
crossi updated this revision to Diff 74021.
crossi added a comment.
Following discussion with @ervin and @broulik, export generated KConfig
settings, remove singleton option. The KCM will have its own KConfig settings'
instance like other KCMs.
REPOSITORY
R120 Plasma Workspace
CHANGES
crossi planned changes to this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26047
To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus,
crossi updated this revision to Diff 73214.
crossi added a comment.
Add API documentation
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26047?vs=71676=73214
REVISION DETAIL
https://phabricator.kde.org/D26047
AFFECTED FILES
ervin added inline comments.
INLINE COMMENTS
> settings.h:343
>
> +QList configSkeletons() const;
> +
Will need API documentation
> broulik wrote in settings.h:343
> Not a fan of this becoming public API
@broulik I understand you don't like much this becoming exposed as one could
abuse
crossi added inline comments.
INLINE COMMENTS
> broulik wrote in settings.h:343
> Not a fan of this becoming public API
Maybe not the best approach.
Any suggestion to access the KCoreConfigSkeleton encapsulated to register them
in the KCM's ConfigModule ?
REPOSITORY
R120 Plasma Workspace
broulik added inline comments.
INLINE COMMENTS
> settings.h:343
>
> +QList configSkeletons() const;
> +
Not a fan of this becoming public API
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26047
To: crossi, #plasma, #frameworks, ervin, bport,
meven resigned from this revision.
meven added a comment.
This revision now requires review to proceed.
Someone else should valide this.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26047
To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson,
meven accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26047
To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart, meven
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,
crossi created this revision.
crossi added reviewers: Plasma, Frameworks, ervin, bport, davidedmundson, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.
REVISION SUMMARY
For KCM Notification, allow to register the generated
14 matches
Mail list logo