D26197: Display fully qualified class/namespace name as page header

2019-12-27 Thread David Redondo 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R264:816abe85ad6a: Display fully qualified class/namespace 
name as page header (authored by davidre).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26197?vs=72120&id=72247#toc

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26197?vs=72120&id=72247

REVISION DETAIL
  https://phabricator.kde.org/D26197

AFFECTED FILES
  src/kapidox/data/templates/library.html
  src/kapidox/generator.py

To: davidre, ochurlaud
Cc: ngraham, aacid, jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, bruns, skadinna

D26197: Display fully qualified class/namespace name as page header

2019-12-26 Thread Olivier Churlaud 
ochurlaud added a comment.


  One minor correction then you can ship it

INLINE COMMENTS

> generator.py:456
> +else:
> +mapping['classname'] = mapping['fullname'] = None
>  

Prefer the use of 2 settings to None instead of this double one. It's more 
explicit for people not coming from python (majority here).

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26197

To: davidre, ochurlaud
Cc: ngraham, aacid, jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, bruns, skadinna

D26197: Display fully qualified class/namespace name as page header

2019-12-24 Thread Elvis Angelaccio 
elvisangelaccio added a reviewer: ochurlaud.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26197

To: davidre, ochurlaud
Cc: ngraham, aacid, jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, bruns, skadinna

D26197: Display fully qualified class/namespace name as page header

2019-12-24 Thread Nathaniel Graham 
ngraham added a comment.


  Looks sensible to me too FWIW.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26197

To: davidre
Cc: ngraham, aacid, jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, bruns, skadinna

D26197: Display fully qualified class/namespace name as page header

2019-12-24 Thread Albert Astals Cid 
aacid added a comment.


  I've no idea about the code, but looks sensible to me, so take this as a +2 
if noone reviews in a while i guess :)

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26197

To: davidre
Cc: aacid, jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26197: Display fully qualified class/namespace name as page header

2019-12-23 Thread David Redondo 
davidre edited the summary of this revision.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26197

To: davidre
Cc: jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26197: Display fully qualified class/namespace name as page header

2019-12-23 Thread David Redondo 
davidre edited the test plan for this revision.
davidre added a subscriber: jucato.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26197

To: davidre
Cc: jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26197: Display fully qualified class/namespace name as page header

2019-12-23 Thread David Redondo 
davidre edited the test plan for this revision.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26197

To: davidre
Cc: jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26197: Display fully qualified class/namespace name as page header

2019-12-23 Thread David Redondo 
davidre created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  It's the most important information to see quickly  what the page is about.
  Using the fully qualified name contains the knowledge which namespace 
contains a
  class/another namespace required which is helpful if one wants to use it in 
their
  own code.

REPOSITORY
  R264 KApiDox

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26197

AFFECTED FILES
  src/kapidox/data/templates/library.html
  src/kapidox/generator.py

To: davidre
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna