D26208: [KEmailAddress] Remove redundant bool var

2020-01-02 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R270:9e8f0306b549: [KEmailAddress] Remove redundant bool var (authored by ahmadsamir). REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26208?vs=72142=72611 REVISION

D26208: [KEmailAddress] Remove redundant bool var

2019-12-30 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R270 KCodecs BRANCH l-ununsed-bool (branched from master) REVISION DETAIL https://phabricator.kde.org/D26208 To: ahmadsamir, dfaure, ngraham Cc: meven, kde-frameworks-devel, LeGast00n, GB_2,

D26208: [KEmailAddress] Remove redundant bool var

2019-12-30 Thread Méven Car
meven added a comment. Seems fine to me, indeed this bool was never changed REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D26208 To: ahmadsamir, dfaure Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26208: [KEmailAddress] Remove redundant bool var

2019-12-30 Thread Ahmad Samir
ahmadsamir added a comment. Ping. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D26208 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26208: [KEmailAddress] Remove redundant bool var

2019-12-24 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added a reviewer: dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY It looks like 'bool tooManyAtsFlag' was copied over from isValidAddress() (where it's actually used/useful) to