This revision was automatically updated to reflect the committed changes.
Closed by commit R246:633a9f22340b: Port QRegExp to QRegularExpression
(authored by ahmadsamir).
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26211?vs=76705=76724
REVISION DETAIL
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Thanks, guess that should go in now.
REPOSITORY
R246 Sonnet
BRANCH
l-qregularexpression (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26211
To:
ahmadsamir updated this revision to Diff 76705.
ahmadsamir added a comment.
- Move the QRegularExpression definition out of the for loop, more efficient
as it'll reused
- match() always allocates a QRegularExpressionMatch anyway, so move it
inside the while loop
- Make the first ()
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
Actually, one can re-use this regex for all files by moving it before the
scope of the loop, or?
The match on the other side is allocated per match() call, I would just move
ahmadsamir updated this revision to Diff 72149.
ahmadsamir added a comment.
Use capturedRef(), cheaper
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26211?vs=72148=72149
BRANCH
l-qregularexpression (branched from master)
REVISION DETAIL
apol added a comment.
Looks good otherwise
INLINE COMMENTS
> parsetrigrams.cpp:59
> +if (match.hasMatch()) {
> +models[fname][line.left(3)] = match.captured(2).toInt();
> }
capturedRef
REPOSITORY
R246 Sonnet
REVISION DETAIL
ahmadsamir created this revision.
ahmadsamir added reviewers: cullmann, apol.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
TEST PLAN
make && ctest
REPOSITORY
R246 Sonnet
BRANCH
l-qregularexpression (branched from master)
REVISION DETAIL
