ahmadsamir added inline comments.
INLINE COMMENTS
> dfaure wrote in kuitmarkup.cpp:1597
> I thought it was the resolved version, without entities (if they were
> successfully resolved).
If the entity is unknown it'll be left as is, I don't know how often that
actually happens though.
ahmadsamir added a task: T12279: Port frameworks away from QRegExp.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D26285
To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, ltoscano, LeGast00n, GB_2, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:f9b932d254c4: [KuitFormatterPrivate] Start porting
QRegExp to QRegularExpression (authored by ahmadsamir).
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
dfaure accepted this revision.
REPOSITORY
R249 KI18n
BRANCH
l-finalizeVisualText (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26285
To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, ltoscano, LeGast00n, GB_2, michaelh, ngraham,
ahmadsamir updated this revision to Diff 72567.
ahmadsamir added a comment.
Ternary that doesn't return a value is weird, better avoid.
"Grammar fixes" in comments add noise to the diff, be kind to reviewers.
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
I wonder if others agree that "a ? b() : c()" is bad form for void b() and
void c(), compared to an if(), or if it's just me.
INLINE COMMENTS
> kuitmarkup.cpp:1582
> +//
ahmadsamir added inline comments.
INLINE COMMENTS
> dfaure wrote in kuitmarkup.cpp:1342
> Duplication :-)
>
> Dangerous, if the actual char* is modified one day.
Personally, I needed to see the actual regex spelled out like that to
understand the rest of the code in this function, this:
ahmadsamir updated this revision to Diff 72539.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.
Address comments
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26285?vs=72363=72539
BRANCH
l-finalizeVisualText (branched from
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kuitmarkup.cpp:1332
>
> -#define ENTITY_SUBRX "[a-z]+|#[0-9]+|#x[0-9a-fA-F]+"
> +const QString ENTITY_SUBRX =
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, ilic, dfaure, mlaurent, aacid.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
Port toVisualText() and finalizeVisualText() to use QRegularExpression.
Replace
10 matches
Mail list logo
