This revision was automatically updated to reflect the committed changes.
Closed by commit R280:99009fc60051: endl is namespaced in qt5.15 (authored by
mlaurent).
REPOSITORY
R280 Prison
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26299?vs=72510=72591
REVISION DETAIL
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R280 Prison
BRANCH
compile_against_qt5.15 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26299
To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2,
mlaurent updated this revision to Diff 72510.
mlaurent added a comment.
Use '\n'
REPOSITORY
R280 Prison
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26299?vs=72415=72510
BRANCH
compile_against_qt5.15 (branched from master)
REVISION DETAIL
apol added inline comments.
INLINE COMMENTS
> prison-datamatrix.cpp:39
>QTextStream str(stdout);
> - str << error << ": " << errormessage << endl;
> + str << error << ": " << errormessage
> + #if (QT_VERSION < QT_VERSION_CHECK(5, 15, 0))
Wouldn't make more sense to port to std::endl
mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
Port to Qt::endl in qt5.15
REPOSITORY
R280 Prison
BRANCH
compile_against_qt5.15 (branched from master)
mlaurent added a reviewer: dfaure.
REPOSITORY
R280 Prison
REVISION DETAIL
https://phabricator.kde.org/D26299
To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
