D26299: endl is namespaced in qt5.15

2020-01-01 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R280:99009fc60051: endl is namespaced in qt5.15 (authored by 
mlaurent).

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26299?vs=72510&id=72591

REVISION DETAIL
  https://phabricator.kde.org/D26299

AFFECTED FILES
  src/tools/prison-datamatrix.cpp

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26299: endl is namespaced in qt5.15

2020-01-01 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R280 Prison

BRANCH
  compile_against_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26299

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26299: endl is namespaced in qt5.15

2020-01-01 Thread Laurent Montel 
mlaurent updated this revision to Diff 72510.
mlaurent added a comment.


  Use '\n'

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26299?vs=72415&id=72510

BRANCH
  compile_against_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26299

AFFECTED FILES
  src/tools/prison-datamatrix.cpp

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26299: endl is namespaced in qt5.15

2019-12-31 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> prison-datamatrix.cpp:39
>QTextStream str(stdout);
> -  str << error << ": " << errormessage << endl;
> +  str << error << ": " << errormessage
> +   #if (QT_VERSION < QT_VERSION_CHECK(5, 15, 0))

Wouldn't make more sense to port to std::endl which as been around since 
forever? Or pass a '\n'.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D26299

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26299: endl is namespaced in qt5.15

2019-12-30 Thread Laurent Montel 
mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port to Qt::endl in qt5.15

REPOSITORY
  R280 Prison

BRANCH
  compile_against_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26299

AFFECTED FILES
  src/tools/prison-datamatrix.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26299: endl is namespaced in qt5.15

2019-12-30 Thread Laurent Montel 
mlaurent added a reviewer: dfaure.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D26299

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns