D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2020-01-01 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R238:48b3c03fc710: Port endl to \n. endl in qt5.15 
is namespaced. We dont need to flush as when… (authored by mlaurent).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26317?vs=72514=72530

REVISION DETAIL
  https://phabricator.kde.org/D26317

AFFECTED FILES
  src/docbookl10nhelper.cpp

To: mlaurent, dfaure, aacid
Cc: ltoscano, aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, 
LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2020-01-01 Thread Albert Astals Cid 
aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure, aacid
Cc: ltoscano, aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, 
LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2020-01-01 Thread Laurent Montel 
mlaurent updated this revision to Diff 72514.
mlaurent added a comment.


  merge \n

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26317?vs=72444=72514

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26317

AFFECTED FILES
  src/docbookl10nhelper.cpp

To: mlaurent, dfaure
Cc: ltoscano, aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, 
LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-31 Thread Luigi Toscano 
ltoscano added a comment.


  In D26317#585315 , @aacid wrote:
  
  > Isn't it better to just use `Qt::endl` ?
  >
  > I think it's much clearer to understand `Qt::endl` than `QLatin1Char('\n')`
  >
  > But if we prefer to change to use \n it should be merged into the existing 
strings, doesn't make much sense to do 
  >  `outStream << "" << QLatin1Char('\n');`
  >  instead of
  >  `outStream << "\n';`
  
  
  I agree with Albert here; I think it's a bit more painful but it's probably 
going to be cleaner.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: ltoscano, aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, 
LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-31 Thread Albert Astals Cid 
aacid added a comment.


  Ah, it works fine in 5.14.
  
  I was going to say we must report to Qt immediately that they broke source 
compatibility and that was unacceptable but then i realized that the old non 
namespaced version works just fine, it's just deprecated.
  
  I'm going to go back to party preparations :)

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-31 Thread Laurent Montel 
mlaurent added a comment.


  "/compile/kde5/framework/frameworks/kdoctools/src/docbookl10nhelper.cpp: Dans 
la fonction « int writeLangFile(const QString&, const QString&, const 
LangListType&) »:
  /compile/kde5/framework/frameworks/kdoctools/src/docbookl10nhelper.cpp:62:57: 
erreur: « endl » n'est pas un membre de « Qt »
  
62 |   .arg(dtdPath) << QLatin1Char('\n') << Qt::endl;
  
  "
  no it's not :) qt5.13 :)

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-31 Thread Laurent Montel 
mlaurent added a comment.


  "No, it's not. It's namespaced in Qt 5.15 means it should be ifdef guarded 
which makes things to suck." yep it's for that I switched to "\n"
  
  I don't want to add #ifdef if it's not necessary.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-31 Thread Albert Astals Cid 
aacid added a comment.


  But it is already namespaced in older Qt too, so no ifdef needed

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-31 Thread Anthony Fieroni 
anthonyfieroni added a comment.


  In D26317#585315 , @aacid wrote:
  
  > Isn't it better to just use `Qt::endl` ?
  
  
  No, it's not. It's namespaced in Qt 5.15 means it should be ifdef guarded 
which makes things to suck.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-31 Thread Albert Astals Cid 
aacid added a comment.


  Isn't it better to just use `Qt::endl` ?
  
  I think it's much clearer to understand `Qt::endl` than `QLatin1Char('\n')`
  
  But if we prefer to change to use \n it should be merged into the existing 
strings, doesn't make much sense to do 
  `outStream << "" << QLatin1Char('\n');`
  instead of
  `outStream << "\n';`

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-30 Thread Laurent Montel 
mlaurent added a comment.


  "Also QStringLiteral is missing on some strings." it can be fix in other 
patch.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-30 Thread Laurent Montel 
mlaurent updated this revision to Diff 72444.
mlaurent added a comment.


  use QLatin1Char('\n')

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26317?vs=72440=72444

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26317

AFFECTED FILES
  src/docbookl10nhelper.cpp

To: mlaurent, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-30 Thread Anthony Fieroni 
anthonyfieroni added a comment.


  Will be better if you use QLatin1Char('\n'), "\n" will call strlen on which 
is unneeded. Also QStringLiteral is missing on some strings.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-30 Thread Laurent Montel 
mlaurent added a reviewer: dfaure.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-30 Thread Laurent Montel 
mlaurent created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl to \n

REPOSITORY
  R238 KDocTools

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26317

AFFECTED FILES
  src/docbookl10nhelper.cpp

To: mlaurent
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna