D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

2020-01-02 Thread Méven Car 
meven planned changes to this revision.
meven added a comment.


  In D26361#586350 , @ervin wrote:
  
  > Indeed will have to wait KF6 branching AFAICT. Could you add a task for it 
in the KF6 board in the waiting for branching column? Just to make sure we 
don't forget it.
  
  
  Added a bullet to https://phabricator.kde.org/T12147 and created 
https://phabricator.kde.org/T12480

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26361

To: meven, ervin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

2020-01-02 Thread Kevin Ottens 
ervin added a comment.


  Indeed will have to wait KF6 branching AFAICT. Could you add a task for it in 
the KF6 board in the waiting for branching column? Just to make sure we don't 
forget it.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26361

To: meven, ervin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

2020-01-02 Thread Méven Car 
meven added a comment.


  The methods are straight copy-paste compared to KCoreConfigSkeleton.
  The binary compatiblity might be affected though so we might want to do it 
for KF6 only.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26361

To: meven, ervin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

2020-01-02 Thread Méven Car 
meven created this revision.
meven added reviewers: ervin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26361

AFFECTED FILES
  src/kcmodule.cpp
  src/kcmodule.h
  src/kconfigdialogmanager.cpp
  src/kconfigdialogmanager.h

To: meven, ervin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns