This revision was automatically updated to reflect the committed changes.
Closed by commit R293:71fb41ae9ae8: Migrate config from KConfig to KConfigXt in
order to allow KCM to use it (authored by bport).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
ervin accepted this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D26400
To: bport, ervin, crossi, meven, #plasma, bruns
Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77,
lots0logs, LeGast00n, fbampaloukas, GB_2, domson,
ervin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D26400
To: bport, ervin, crossi, meven, #plasma, bruns
Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77,
lots0logs,
bport updated this revision to Diff 72909.
bport added a comment.
fix
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26400?vs=72908=72909
REVISION DETAIL
https://phabricator.kde.org/D26400
AFFECTED FILES
src/file/CMakeLists.txt
bport updated this revision to Diff 72908.
bport added a comment.
Take in consideration ervin feedback
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26400?vs=72701=72908
REVISION DETAIL
https://phabricator.kde.org/D26400
AFFECTED FILES
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.
Two smaller issues, nothing critical
INLINE COMMENTS
> baloosettings.kcfgc:6
> +DefaultValueGetters=true
> +GenerateProperties=true
> +ParentInConstructor=true
I don't think
lbeltrame added a reviewer: bruns.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D26400
To: bport, ervin, crossi, meven, #plasma, bruns
Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77,
lots0logs, LeGast00n, fbampaloukas, GB_2, domson,
bport added a dependent revision: D26401: KCM Baloo: Migrate to KConfigXT and
add immutability.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D26400
To: bport, ervin, crossi, meven, #plasma
Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77,
bport added reviewers: ervin, crossi, meven, Plasma.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D26400
To: bport, ervin, crossi, meven, #plasma
Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77,
lots0logs, LeGast00n, fbampaloukas, GB_2,
bport created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bport requested review of this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D26400
AFFECTED FILES
src/file/CMakeLists.txt
10 matches
Mail list logo