D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-11-21 Thread Méven Car
meven added a comment. ping @nicolasfella INLINE COMMENTS > kdiroperator.h:425 > */ > KActionCollection *actionCollection() const; > Mark it deprecated / add a // KF6 TODO remove ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella,

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-06 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > meven wrote in kdiroperator.h:428 > Personally I would add an enum of static strings, so that user code can > discover easily the features and that the documentation follows the code more > easily. What's an enum of strings? You mean just an

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-06 Thread Méven Car
meven added inline comments. INLINE COMMENTS > dhaumann wrote in kdiroperator.h:428 > Imho the API documentation should be improved (I am aware it was copied). > > Returns a map of all available actions. The action map remains unchanged > throughout the entire lifetime of the diroperator

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-05 Thread David Faure
dfaure added a comment. Interesting suggestion. We're used to using names for actions everywhere, but in this specific case an enum would do indeed. When this is ported away from KActionCollection in the future, one should remember to do action->setObjectName("...") for code that

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-05 Thread Albert Astals Cid
aacid added a comment. Why are we using a string instead of an enum? It's not like this is KXMLGui where people can define their own actions, is it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: dhaumann, aacid,

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-05 Thread David Faure
dfaure added a comment. +1, API and code look good REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: dhaumann, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-05 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > kdiroperator.h:428 > +/** > + * an accessor to a collection of all available Actions. The actions > + * are static, they will be there all the time. Imho the API documentation should be improved (I am aware it was copied). Returns

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-04 Thread Nicolas Fella
nicolasfella added a comment. The goal is to remove the overall dependencies of KIO. There are multiple apps/other frameworks that use KIO without using KXmlGui. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: aacid,

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-04 Thread Albert Astals Cid
aacid added a comment. What's the point of removing the KXMLGui dependency? I mean it's not like you will be able to do Kate or KDevelop without kxmlgui, no? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: aacid,

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-04 Thread Nicolas Fella
nicolasfella edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-04 Thread Nicolas Fella
nicolasfella edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-04 Thread Nicolas Fella
nicolasfella updated this revision to Diff 72772. nicolasfella added a comment. - Add since REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26424?vs=72771=72772 BRANCH kac REVISION DETAIL https://phabricator.kde.org/D26424 AFFECTED FILES

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-04 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY To replace the actionCollection() method. This will allow

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-04 Thread Nicolas Fella
nicolasfella added a task: T12205: Port KDirOperator away from KActionCollection. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns