kossebau added a comment.
And now reported the challenge of drop objects lifetime vs user input on
decisions by https://bugreports.qt.io/browse/QTBUG-125229
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio,
kossebau added a comment.
Hi. I just came across dropping random data (in my case an image) into file
views not working, i.e. not creating any new files due to no more data in the
QMimeData instance referred to in the DropJob.
Looking into the details, it seems this is due to the flaw
trmdi added a dependent revision: D26514: Delay popup for containments.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2,
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:fbb2be9aad19: Add KIO::DropJobFlag to allow manually
showing the menu (authored by trmdi).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26484?vs=73399=73400
trmdi updated this revision to Diff 73399.
trmdi added a comment.
- Comment
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26484?vs=73364=73399
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26484
AFFECTED FILES
src/widgets/dropjob.cpp
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
You can land after making these last minute adjustments, no need for another
round of review :)
INLINE COMMENTS
> dropjob.h:83
> + * @since 5.67
> + **/
> +void showMenu(const
trmdi updated this revision to Diff 73364.
trmdi added a comment.
- Typo
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26484?vs=73363=73364
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26484
AFFECTED FILES
src/widgets/dropjob.cpp
trmdi marked 3 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2,
michaelh, bruns
trmdi updated this revision to Diff 73363.
trmdi added a comment.
- Improve comment/doc
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26484?vs=73337=73363
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26484
AFFECTED FILES
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Almost there.
Please add @since 5.67 to the new enum and the new methods.
INLINE COMMENTS
> dfaure wrote in dropjob.cpp:416
> This '{' goes on its own line.
Not fixed.
>
trmdi edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2,
michaelh, bruns
trmdi retitled this revision from "Add KIO::DropJobFlag flag and
DropJob::menuPopup()" to "Add KIO::DropJobFlag to allow manually showing the
menu".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
12 matches
Mail list logo
