trmdi removed a dependent revision: D26514: Delay popup for containments.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2,
trmdi edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
ngraham, bruns
trmdi updated this revision to Diff 73175.
trmdi added a comment.
- Simplify the approach
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26484?vs=73114=73175
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26484
AFFECTED FILES
trmdi planned changes to this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
ngraham, bruns
trmdi updated this revision to Diff 73114.
trmdi added a comment.
- Improve code
- Improve code
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26484?vs=73113=73114
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26484
AFFECTED FILES
trmdi updated this revision to Diff 73113.
trmdi added a comment.
- Improve code
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26484?vs=73112=73113
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26484
AFFECTED FILES
src/core/job_base.h
trmdi updated this revision to Diff 73112.
trmdi added a comment.
- Remove the new signal and show a "Fetching data" menu while delaying
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26484?vs=73076=73112
BRANCH
master
REVISION DETAIL
trmdi planned changes to this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
ngraham, bruns
trmdi edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
ngraham, bruns
trmdi marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
ngraham, bruns
trmdi updated this revision to Diff 73076.
trmdi added a comment.
- Move delayPopup to JobFlag
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26484?vs=73030=73076
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26484
AFFECTED FILES
broulik added a comment.
I don't fully understand why `popupMenuAboutToShow` isn't sufficient.
An alternative approach I could think would be allowing the signal handler to
delay the menu as necessary rather than having to create the drop job
differently?
INLINE COMMENTS
> dropjob.h:131
trmdi marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
trmdi updated this revision to Diff 73030.
trmdi added a comment.
- Add a new function instead of changing the old exported one
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26484?vs=72975=73030
BRANCH
master
REVISION DETAIL
anthonyfieroni added inline comments.
INLINE COMMENTS
> dropjob.h:129
> */
> -KIOWIDGETS_EXPORT DropJob *drop(const QDropEvent *dropEvent, const QUrl
> , JobFlags flags = DefaultFlags);
> +KIOWIDGETS_EXPORT DropJob *drop(const QDropEvent *dropEvent, const QUrl
> , JobFlags flags =
trmdi added a dependent revision: D26514: Delay popup for containments.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
trmdi edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
trmdi edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
trmdi retitled this revision from "Delay 100ms before showing the menu" to "Add
a new parameter for delaying showing menu".
trmdi edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson,
19 matches
Mail list logo
