This revision was automatically updated to reflect the committed changes.
Closed by commit R240:ee0531749057: Add missing Import Env Variable (authored
by tcanabrava).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26573?vs=74512=74513
REVISION
tcanabrava updated this revision to Diff 74512.
tcanabrava added a comment.
- Fix Variable
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26573?vs=73237=74512
BRANCH
add_missing_env_var
REVISION DETAIL
https://phabricator.kde.org/D26573
apol added a comment.
I don't really understand why this is needed, I've never needed that at least.
Having @davidedmundson's patch would be interesting too, although we might
want to support earlier versions that won't get the patch.
REPOSITORY
R240 Extra CMake Modules
BRANCH
davidedmundson added a comment.
I'm now affected by this :(
I think this shouldn't be needed, but I have no objections to merging this
either.
https://codereview.qt-project.org/c/qt/qtquickcontrols2/+/288238
REPOSITORY
R240 Extra CMake Modules
BRANCH
add_missing_env_var
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
add_missing_env_var
REVISION DETAIL
https://phabricator.kde.org/D26573
To: tcanabrava, mart
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,
tcanabrava created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
tcanabrava requested review of this revision.
REVISION SUMMARY
Without this, in Qt 5.14 I get an android-like QQC2 theme
This used to work on Qt
