D26600: Refactor fstab handling

2021-10-13 Thread Méven Car
meven added a comment. Would be great to continue this. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26600 To: hallas, #frameworks, bruns, meven Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ahmadsamir, ngraham, bruns, vkrause

D26600: Refactor fstab handling

2020-02-04 Thread Méven Car
meven added inline comments. INLINE COMMENTS > system_filesystem_table_test.cpp:55 > +"devices /sys/fs/cgroup/devices cgroup > rw,nosuid,nodev,noexec,relatime,devices 0 0\n" > +"freezer /sys/fs/cgroup/freezer cgroup > rw,nosuid,nodev,noexec,relatime,freezer 0 0\n" > +"net_cls

D26600: Refactor fstab handling

2020-01-18 Thread David Hallas
hallas added a comment. In D26600#596631 , @bruns wrote: > and this is definitely too much code being moved around. Please split this up into multiple reviews. > > You should likely start with the introduction of the FilesystemEntry class,

D26600: Refactor fstab handling

2020-01-18 Thread Stefan Brüns
bruns added a comment. and this is definitely too much code being moved around. Please split this up into multiple reviews. You should likely start with the introduction of the FilesystemEntry class, use that from the existing code. REPOSITORY R245 Solid REVISION DETAIL

D26600: Refactor fstab handling

2020-01-18 Thread David Hallas
hallas added a comment. In D26600#596533 , @bruns wrote: > Moving existing code to new files does not make you the copyright owner. Yes, sorry about that - I need to fix that. This is just my editor, when I create new files this is the

D26600: Refactor fstab handling

2020-01-18 Thread Stefan Brüns
bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Moving existing code to new files does not make you the copyright owner. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26600 To: hallas, #frameworks,

D26600: Refactor fstab handling

2020-01-18 Thread Alex Debus
alexde retitled this revision from "Refator fstab handling" to "Refactor fstab handling". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26600 To: hallas, #frameworks, bruns, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns