D26697: Message-related methods: Use more member-function-pointer-based connect

2020-01-30 Thread Dominik Haumann 
dhaumann added a comment.


  In two days we have the next KDE Frameworks tag. I'd have preferred a commit 
on Sunday ;)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D26697

To: kossebau, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26697: Message-related methods: Use more member-function-pointer-based connect

2020-01-30 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:6db5cb3ea2ba: Message-related methods: Use more 
member-function-pointer-based connect (authored by kossebau).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26697?vs=74711&id=74724

REVISION DETAIL
  https://phabricator.kde.org/D26697

AFFECTED FILES
  src/document/katedocument.cpp
  src/view/katemessagewidget.cpp

To: kossebau, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26697: Message-related methods: Use more member-function-pointer-based connect

2020-01-30 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks ok, too, thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  moremodernconnect

REVISION DETAIL
  https://phabricator.kde.org/D26697

To: kossebau, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26697: Message-related methods: Use more member-function-pointer-based connect

2020-01-30 Thread Friedrich W. H. Kossebau 
kossebau updated this revision to Diff 74711.
kossebau added a comment.


  rebase to latest master
  ping? :)

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26697?vs=73660&id=74711

BRANCH
  moremodernconnect

REVISION DETAIL
  https://phabricator.kde.org/D26697

AFFECTED FILES
  src/document/katedocument.cpp
  src/view/katemessagewidget.cpp

To: kossebau, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26697: Message-related methods: Use more member-function-pointer-based connect

2020-01-15 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
kossebau added a reviewer: dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26697

AFFECTED FILES
  src/document/katedocument.cpp
  src/view/katemessagewidget.cpp

To: kossebau, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann