D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3dfa0c1c2f87: KFilePlacesModel: On new profile in recent show only recentlyused:/ based… (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D26782_1 REVISION DETAIL https://phabricator.kde.org/D26782 To: meven, ngraham, #vdg, #plasma, hein Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven updated this revision to Diff 74123. meven added a comment. Fix comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=74072=74123 BRANCH arcpatch-D26782_1 REVISION DETAIL https://phabricator.kde.org/D26782 AFFECTED FILES

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

ngraham accepted this revision. ngraham added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kfileplacesmodel.cpp:358 > + > +// don't add by default "Modifield Today" and "Modifield Yesterday" > when recentlyused:/ is present > +if

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven updated this revision to Diff 74071. meven added a comment. Don't add by default 'Modifield Today' and 'Modifield Yesterday' when recentlyused:/ is present REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=73995=74071 BRANCH arcpatch-D26782

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven updated this revision to Diff 74072. meven added a comment. Clean up REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=74071=74072 BRANCH arcpatch-D26782 REVISION DETAIL https://phabricator.kde.org/D26782 AFFECTED FILES

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

ngraham added a comment. In D26782#597916 , @meven wrote: > In D26782#597811 , @ngraham wrote> > > > But should we just hide them, or not even create them in the first place? Creating

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven updated this revision to Diff 73995. meven marked an inline comment as done. meven added a comment. Added missing spaces REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=73917=73995 BRANCH arcpatch-D26782 REVISION DETAIL

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven added a comment. In D26782#597811 , @ngraham wrote> > But should we just hide them, or not even create them in the first place? Creating hidden-by-default entries seems a bit off. I chose hidden by value just to keep the feature

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

ngraham added a comment. Oh, I thought we already did this. +1 since it was explicitly the plan. But should we just hide them, or not even create them in the first place? Creating hidden-by-default entries seems a bit off. INLINE COMMENTS > kfileplacesmodel.cpp:361 >

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven added a comment. Too bad I missed the boat for KF 5.66 and Plasma 5.18. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26782 To: meven, ngraham, #vdg, #plasma, hein Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven edited the summary of this revision. meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26782 To: meven, ngraham, #vdg, #plasma, hein Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven updated this revision to Diff 73917. meven added a comment. Clean commit REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=73916=73917 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26782 AFFECTED FILES

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

meven created this revision. meven added reviewers: ngraham, VDG, Plasma, hein. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY The entries timeline:/today and timeline:/yesterday are way less useful