This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:8dfb727dd105: hardware tool: define syntax via syntax arg
(authored by sitter).
REPOSITORY
R245 Solid
CHANGES SINCE
sitter updated this revision to Diff 74780.
sitter added a comment.
set HidenFromHelp flag on legacy option so it doesn't even show up anymore
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26841?vs=74112&id=74780
BRANCH
master
REVISION DETAIL
https://p
sitter added a comment.
Splendid idea!
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D26841
To: sitter
Cc: broulik, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham
broulik added a comment.
Oh god yes.
Since it's only for compat and superfluous, how about setting
`HiddenFromHelp` on the `QCommandLineOption` then?
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D26841
To: sitter
Cc: broulik, bruns, kde-frameworks-devel, LeGast
sitter edited the summary of this revision.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D26841
To: sitter
Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham
bruns added a comment.
Please do proper capitalization in the summary.
And "nothing infurates me more" is not relevant for a commit message.
Otherwise LGTM.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D26841
To: sitter
Cc: bruns, kde-frameworks-devel, LeGa
sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
this way the commands syntax is always immediately visible
in the help text.
nothing infurates me more than help that
