D26841: hardware tool: define syntax via syntax arg

2020-03-10 Thread Harald Sitter 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:8dfb727dd105: hardware tool: define syntax via syntax arg 
(authored by sitter).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26841?vs=74780=77352

REVISION DETAIL
  https://phabricator.kde.org/D26841

AFFECTED FILES
  src/tools/solid-hardware/solid-hardware.cpp

To: sitter
Cc: broulik, bruns, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham

D26841: hardware tool: define syntax via syntax arg

2020-01-31 Thread Harald Sitter 
sitter updated this revision to Diff 74780.
sitter added a comment.


  set HidenFromHelp flag on legacy option so it doesn't even show up anymore

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26841?vs=74112=74780

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26841

AFFECTED FILES
  src/tools/solid-hardware/solid-hardware.cpp

To: sitter
Cc: broulik, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26841: hardware tool: define syntax via syntax arg

2020-01-31 Thread Harald Sitter 
sitter added a comment.


  Splendid idea!

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26841

To: sitter
Cc: broulik, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26841: hardware tool: define syntax via syntax arg

2020-01-31 Thread Kai Uwe Broulik 
broulik added a comment.


  Oh god yes.
  
  Since it's only for compat and superfluous, how about setting 
`HiddenFromHelp` on the `QCommandLineOption` then?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26841

To: sitter
Cc: broulik, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26841: hardware tool: define syntax via syntax arg

2020-01-22 Thread Harald Sitter 
sitter edited the summary of this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26841

To: sitter
Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26841: hardware tool: define syntax via syntax arg

2020-01-22 Thread Stefan Brüns 
bruns added a comment.


  Please do proper capitalization in the summary.
  
  And "nothing infurates me more" is not relevant for a commit message.
  
  Otherwise LGTM.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26841

To: sitter
Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26841: hardware tool: define syntax via syntax arg

2020-01-22 Thread Harald Sitter 
sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this way the commands syntax is always immediately visible
  in the help text.
  nothing infurates me more than help that doesn't help, and
  previously the help would essentially just end up telling you to
  run --commands to actually get help -.-
  
  the existing syntax argument of addPositionArgument will simply
  print the syntax help undearneath the usage line, thus giving
  immediate access to information on how to use the application
  without first having to go through the --commands argument
  
  (--commands still exists for backwards compat)

TEST PLAN
  -h now useful

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26841

AFFECTED FILES
  src/tools/solid-hardware/solid-hardware.cpp

To: sitter
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns