This revision was automatically updated to reflect the committed changes.
Closed by commit R241:fe5913b1346a: Add missing renamed event when a
destination file already existed (authored by meven).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
meven updated this revision to Diff 74324.
meven marked 3 inline comments as done.
meven added a comment.
Clean up + QVERIFY
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26878?vs=74316=74324
BRANCH
arcpatch-D26878
REVISION DETAIL
dfaure accepted this revision.
dfaure added a comment.
Nice work! Thanks for the unittest extension.
INLINE COMMENTS
> jobtest.cpp:1731
> +
> +qDebug() << sourceFile << renamedFile;
> +QVERIFY2(job->exec(), qPrintable(job->errorString()));
Please clean up before committing
>
meven updated this revision to Diff 74316.
meven added a comment.
Remove a bad unused
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26878?vs=74311=74316
BRANCH
arcpatch-D26878
REVISION DETAIL
https://phabricator.kde.org/D26878
AFFECTED FILES
meven edited the test plan for this revision.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26878
To: meven, #frameworks, ervin, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
meven updated this revision to Diff 74311.
meven added a comment.
Avoid touching a line
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26878?vs=74310=74311
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26878
AFFECTED FILES
meven updated this revision to Diff 74310.
meven retitled this revision from "Add missing renamed events when a
destination file already existed" to "Add missing renamed event when a
destination file already existed".
meven added a comment.
Add tests, add renamed events when autorename was
meven retitled this revision from "Add a missing renamed event when a
destination file already existed" to "Add missing renamed event when a
destination file already existed".
meven edited the summary of this revision.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
