D26903: allow programLogo property to be a QIcon, too

cullmann closed this revision. cullmann added a comment. done https://commits.kde.org/kcoreaddons/7bc9d98a2144baf3a7aa15778a842a9cba5d2263 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D26903 To: cullmann, apol Cc: kossebau, dhaumann, kde-frameworks-devel,

D26903: allow programLogo property to be a QIcon, too

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Then shortly reopen this, otherwise I forget to do this ;=) Thanks for the feedback. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D26903 To: cullmann,

D26903: allow programLogo property to be a QIcon, too

kossebau added a comment. In D26903#600771 , @cullmann wrote: > Would something like this be ok? > > Not sure what to write about sizes, e.g. for the program icon we don't mention anything either. The program icon I have and such

D26903: allow programLogo property to be a QIcon, too

cullmann added a comment. Would something like this be ok? Not sure what to write about sizes, e.g. for the program icon we don't mention anything either. The QPixmap case was missing in the docs, too, btw. diff --git a/src/lib/kaboutdata.h b/src/lib/kaboutdata.h index

D26903: allow programLogo property to be a QIcon, too

kossebau added a comment. I propose to also extend the KAboutData::programLogo documentation to specify that QIcon is supported/expected. So this is not some surprise bebaviour. While at it, please also note there recommended logo pixmap size usages, to avoid blurring. REPOSITORY

D26903: allow programLogo property to be a QIcon, too

This revision was automatically updated to reflect the committed changes. Closed by commit R263:260a3094de02: allow programLogo property to be a QIcon, too (authored by cullmann). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26903?vs=74330=74364 REVISION

D26903: allow programLogo property to be a QIcon, too

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D26903 To: cullmann, apol Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26903: allow programLogo property to be a QIcon, too

dhaumann added a comment. Looks good to me, and very much in line with the other `canConvert` statements before. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D26903 To: cullmann Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26903: allow programLogo property to be a QIcon, too

cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY rational: QIcon allows for better passing of HiDPI aware icons to the dialog TEST PLAN make && make test