This revision was automatically updated to reflect the committed changes.
Closed by commit R39:6f39d3345273: KateModeMenuList: dont overlap the
scroll bar (authored by nibags, committed by cullmann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
This is a patch for KTextEditor, that is still on phab (for good or bad ;=)
I think this is ok, accepting & merging.
Btw., for the default arguments: This is a purely internal class,
nibags updated this revision to Diff 74531.
nibags added a comment.
- Restore parameters
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26957?vs=74479=74531
BRANCH
mode-menu-scrollbar-overlap
REVISION DETAIL
https://phabricator.kde.org/D26957
ngraham added a comment.
JFYI Kate has moved to GitLab and most patches are now submitted at
https://invent.kde.org/kde/kate.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D26957
To: nibags, cullmann, #ktexteditor
Cc: ngraham, anthonyfieroni, kwrite-devel,
anthonyfieroni added a comment.
Don't remove default parameter, it'll break other users.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D26957
To: nibags, cullmann, #ktexteditor
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n,
GB_2,
nibags edited the summary of this revision.
nibags added reviewers: cullmann, KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D26957
To: nibags, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson,
michaelh,
nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.
REPOSITORY
R39 KTextEditor
BRANCH
mode-menu-scrollbar-overlap
REVISION DETAIL
https://phabricator.kde.org/D26957
