This revision was automatically updated to reflect the committed changes.
Closed by commit R278:21d67e31f718: [KWindowShadows] Check for X connection
(authored by broulik).
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26960?vs=74486=74489
REVISION
davidedmundson accepted this revision.
davidedmundson added a comment.
Ok, panel shadows is a singleton. That explains things.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D26960
To: broulik, #plasma, zzag, davidedmundson
Cc: davidedmundson,
davidedmundson added a comment.
Heh, I'm going to quote a conversation with you:
David Edmundson, [17.01.20 10:07]
would you say it's always wrong to have a QWindow outlive a QApplication?
Kai Uwe, [17.01.20 10:08]
I would say yes, why?
David Edmundson, [17.01.20
zzag accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D26960
To: broulik, #plasma, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
broulik created this revision.
broulik added reviewers: Plasma, zzag.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
On teardown of plasmashell the shared pointer with shadows is unref'd quite
