aacid added a comment.
Seems reasonable to me.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D26990
To: leinir, #knewstuff, aacid, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
leinir added reviewers: KNewStuff, aacid, Frameworks.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D26990
To: leinir, #knewstuff, aacid, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
leinir updated this revision to Diff 74574.
leinir added a comment.
- Remove some unrelated changes
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26990?vs=74573=74574
BRANCH
allow-setting-qtquick-itemsmodel-engine-with-either-engine-type (branched
leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.
REVISION SUMMARY
This fixes a regression caused by the initial work to bring KNSQuick
up to feature parity with KNewStuff's widget
