D27038: [KMessageWidget] Allow the style to change our palette

2020-02-25 Thread David Redondo 
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:d946fb71ea22: [KMessageWidget] Allow the style to change 
our palette (authored by davidre).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27038?vs=76408&id=76409

REVISION DETAIL
  https://phabricator.kde.org/D27038

AFFECTED FILES
  src/kmessagewidget.cpp

To: davidre, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27038: [KMessageWidget] Allow the style to change our palette

2020-02-25 Thread David Redondo 
davidre updated this revision to Diff 76408.
davidre added a comment.


  Rebase

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27038?vs=74701&id=76408

BRANCH
  polish

REVISION DETAIL
  https://phabricator.kde.org/D27038

AFFECTED FILES
  src/kmessagewidget.cpp

To: davidre, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27038: [KMessageWidget] Allow the style to change our palette

2020-02-23 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Meh, right. I guess it doesn't matter that much.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  polish (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27038

To: davidre, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27038: [KMessageWidget] Allow the style to change our palette

2020-02-23 Thread David Redondo 
davidre added a comment.


  In D27038#616095 , @apol wrote:
  
  > But then now we are not refreshing the palette when it changes outside, no?
  >
  > How about adding a boolean value when it's already happening to prevent the 
infinite recursion?
  
  
  I refresing the palette when the application palette changes. But yes could 
also do it this way

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27038

To: davidre, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27038: [KMessageWidget] Allow the style to change our palette

2020-02-22 Thread Aleix Pol Gonzalez 
apol added a comment.


  But then now we are not refreshing the palette when it changes outside, no?
  
  How about adding a boolean value when it's already happening to prevent the 
infinite recursion?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27038

To: davidre, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27038: [KMessageWidget] Allow the style to change our palette

2020-02-22 Thread David Redondo 
davidre added a comment.


  Ping

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27038

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27038: [KMessageWidget] Allow the style to change our palette

2020-01-30 Thread David Redondo 
davidre added a dependency: D27035: [KMessageWidget] Draw it with QPainter 
instead of using stylesheet.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27038

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27038: [KMessageWidget] Allow the style to change our palette

2020-01-30 Thread David Redondo 
davidre added a dependent revision: D27039: [KStyle] Set the color of 
KMessageWidgets to the correct one from the current color scheme.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27038

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27038: [KMessageWidget] Allow the style to change our palette

2020-01-30 Thread David Redondo 
davidre created this revision.
davidre added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  After we set our palette give the current QStyle a chance to give us a better
  palette that maybe fits better because we can only use hardcoded colors. To
  avoid infinite recursion when the style calls setPalette on the widget we 
don't
  react to palette change events anymore but when the application palette is
  changed.

TEST PLAN
  N/A

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  polish (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27038

AFFECTED FILES
  src/kmessagewidget.cpp

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns