D27080: Don't warn for invalid plugin metata

2020-02-07 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b76b908e1056: Dont warn for invalid plugin metata 
(authored by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27080?vs=75149=75164

REVISION DETAIL
  https://phabricator.kde.org/D27080

AFFECTED FILES
  src/plasma/pluginloader.cpp

To: ngraham, #plasma, mart, apol
Cc: apol, alex, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27080: Don't warn for invalid plugin metata

2020-02-07 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-warning-spam (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27080

To: ngraham, #plasma, mart, apol
Cc: apol, alex, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27080: Don't warn for invalid plugin metata

2020-02-06 Thread Nathaniel Graham 
ngraham updated this revision to Diff 75149.
ngraham added a comment.


  Use `qCDebug()` instead of removing it

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27080?vs=74823=75149

BRANCH
  less-warning-spam (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27080

AFFECTED FILES
  src/plasma/pluginloader.cpp

To: ngraham, #plasma, mart
Cc: apol, alex, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27080: Don't warn for invalid plugin metata

2020-02-03 Thread Aleix Pol Gonzalez 
apol added a comment.


  Change to qDebug? this is just a result to an ugly workaround and is just a 
symptom of also a performance issue. Silencing it only perpetuates the issue.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27080

To: ngraham, #plasma, mart
Cc: apol, alex, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27080: Don't warn for invalid plugin metata

2020-01-31 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  See explanation in https://bugs.kde.org/show_bug.cgi?id=412464
  
  BUG: 412464
  FIXED-IN: 5.67

TEST PLAN
  restart plasmashell, see way less useless warning spam

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-warning-spam (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27080

AFFECTED FILES
  src/plasma/pluginloader.cpp

To: ngraham, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns