D27087: Add HEIF thumbnailer

2020-02-01 Thread Kai Uwe Broulik
broulik added a comment. https://codereview.qt-project.org/c/qt/qtimageformats/+/236077 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27087 To: zzag, #plasma Cc: cfeck, broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, M

D27087: Add HEIF thumbnailer

2020-02-01 Thread Christoph Feck
cfeck added a comment. Where can we see the status of the HEIF Qt loader? If it correctly implements scaled image loading, then a separate thumbnailer indeed makes not much sense. If, however, it always loads the full image, then scales it down, we got a case for a separate thumbnailer such

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii
zzag added a comment. In D27087#604479 , @broulik wrote: > There's a Qt heif image plug in in the works in Qt. If any, we should help there or at least get our own into kimageformats, so Gwenview and others can open such files properly.

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii
zzag abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27087 To: zzag, #plasma Cc: broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michae

D27087: Add HEIF thumbnailer

2020-02-01 Thread Kai Uwe Broulik
broulik added a comment. -1 for making a dedicated thumbnailer. There's a Qt heif image plug in in the works in Qt. If any, we should help there or at least get our own into kimageformats, so Gwenview and others can open such files properly. REPOSITORY R320 KIO Extras REVISION DETAIL

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii
zzag added a comment. In D27087#604477 , @ngraham wrote: > Very cool. So QImage supports this file format now such that you could open the image in, say, Gwenview? No, as far as I know there is no `QImageIOHandler` for HEIF files. However

D27087: Add HEIF thumbnailer

2020-02-01 Thread Nathaniel Graham
ngraham added a comment. Very cool. So QImage support this file format now such that you could open the image in, say, Gwenview? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27087 To: zzag, #plasma Cc: ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasen

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii
zzag updated this revision to Diff 74836. zzag added a comment. missing copyright stuff in Findlibheif.cmake REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27087?vs=74835&id=74836 BRANCH heic-thumbnailer REVISION DETAIL https://phabricator.kde.org/

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii
zzag edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27087 To: zzag, #plasma Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh,

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii
zzag created this revision. zzag added a reviewer: Plasma. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. zzag requested review of this revision. REPOSITORY R320 KIO Extras BRANCH heic-thumbnailer REVISION DETAIL https://phabricator.k