D27112: Fix errors in the QRegularExpression porting commit

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R269:408bdaa752fa: Fix errors in the QRegularExpression 
porting commit (authored by ahmadsamir).

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27112?vs=77096=77097

REVISION DETAIL
  https://phabricator.kde.org/D27112

AFFECTED FILES
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/Interface.cpp
  tools/bluezapi2qt/Method.cpp
  tools/bluezapi2qt/Properties.cpp

To: ahmadsamir, #frameworks, drosca, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27112: Fix errors in the QRegularExpression porting commit

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77096.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27112?vs=74880=77096

BRANCH
  l-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27112

AFFECTED FILES
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/Interface.cpp
  tools/bluezapi2qt/Method.cpp
  tools/bluezapi2qt/Properties.cpp

To: ahmadsamir, #frameworks, drosca, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27112: Fix errors in the QRegularExpression porting commit

[David Rosca]

drosca accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R269 BluezQt

BRANCH
  l-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27112

To: ahmadsamir, #frameworks, drosca, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27112: Fix errors in the QRegularExpression porting commit

[Ahmad Samir]

ahmadsamir added a comment.


  Can I land this? I keep getting side tracked and I haven't written those unit 
tests, but until then I hate leaving this broken.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D27112

To: ahmadsamir, #frameworks, drosca, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27112: Fix errors in the QRegularExpression porting commit

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM, adding tests would be brilliant.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D27112

To: ahmadsamir, #frameworks, drosca, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27112: Fix errors in the QRegularExpression porting commit

[Ahmad Samir]

ahmadsamir added a comment.


  I'll try and add some unit tests to catch those issues...

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D27112

To: ahmadsamir, #frameworks, drosca, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27112: Fix errors in the QRegularExpression porting commit

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, drosca, apol, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Properties::parse():
  
  - The regex is case sensitive
  - Fix copy/paste error, it's just one space " "
  
  Fix porting of capturedTexts().last() of QRegExp; it should be 
match.captured(1)
  with QRegularExpression if there's one capturing group in the pattern;
  QRegExp capturedTexts() first element is the 0 capturing group which
  captures the whole matched string.

REPOSITORY
  R269 BluezQt

BRANCH
  l-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27112

AFFECTED FILES
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/Interface.cpp
  tools/bluezapi2qt/Method.cpp
  tools/bluezapi2qt/Properties.cpp

To: ahmadsamir, #frameworks, drosca, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns