D27187: update travel-family icons

2020-02-07 Thread Mathis Brüchert
mbruchert added a comment. thank you :D REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: vkrause, ngraham, nicolasfella, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27187: update travel-family icons

2020-02-07 Thread Volker Krause
vkrause added a comment. Awesome work indeed, thanks! I've integrated that in the app, now trying to find all remaining uses of the old one elsewhere. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: vkrause, ngraham,

D27187: update travel-family icons

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. These are lovely icons, BTW. Very nice work. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: ngraham, nicolasfella, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27187: update travel-family icons

2020-02-06 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:cf10c681f350: update travel-family icons (authored by mbruchert, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75132=75135

D27187: update travel-family icons

2020-02-06 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. This looks ready to go. I'll do some additional optimization later. REPOSITORY R266 Breeze Icons BRANCH 4px REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg,

D27187: update travel-family icons

2020-02-06 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75132. mbruchert added a comment. remove accidentially commited icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75131=75132 BRANCH 4px REVISION DETAIL https://phabricator.kde.org/D27187

D27187: update travel-family icons

2020-02-06 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75131. mbruchert added a comment. remove accidentially commited files REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75130=75131 BRANCH 4px REVISION DETAIL https://phabricator.kde.org/D27187

D27187: update travel-family icons

2020-02-06 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75130. mbruchert added a comment. - screenshot icon - 4px border REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75124=75130 BRANCH 4px REVISION DETAIL https://phabricator.kde.org/D27187

D27187: update travel-family icons

2020-02-06 Thread Noah Davis
ndavis added a comment. Much better. Now the margins need to be 4px rather than 3px. If you haven't already, make sure you read the HIG section on icons and the workflow tips wiki page it links to. https://hig.kde.org/style/icons/index.html

D27187: update travel-family icons

2020-02-06 Thread Nicolas Fella
nicolasfella edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: ngraham, nicolasfella, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27187: update travel-family icons

2020-02-06 Thread Mathis Brüchert
mbruchert added a comment. F8088755: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: ngraham, nicolasfella, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27187: update travel-family icons

2020-02-06 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75124. mbruchert added a comment. fix everything for real REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75121=75124 BRANCH screenshot REVISION DETAIL https://phabricator.kde.org/D27187 AFFECTED

D27187: update travel-family icons

2020-02-06 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75121. mbruchert added a comment. - fix everything(px) REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75116=75121 BRANCH screenshot REVISION DETAIL https://phabricator.kde.org/D27187 AFFECTED

D27187: update travel-family icons

2020-02-06 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75116. mbruchert added a comment. fix REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75114=75116 BRANCH screenshot REVISION DETAIL https://phabricator.kde.org/D27187 AFFECTED FILES

D27187: update travel-family icons

2020-02-06 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75114. mbruchert added a comment. - screenshot icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75092=75114 BRANCH screenshot REVISION DETAIL https://phabricator.kde.org/D27187 AFFECTED FILES

D27187: update travel-family icons

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. I think he meant to add some screenshots to the Test Plan section of this patch so people can see the new icons without having to apply it. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc:

D27187: update travel-family icons

2020-02-06 Thread Nicolas Fella
nicolasfella added a comment. Please add some screenshots REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: nicolasfella, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27187: update travel-family icons

2020-02-06 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Whoops, looks like you accidentally made them 48x48 mm instead of 48x48 px :) You'll need to work on the pixel alignment a bit because shrinking them down to the correct size

D27187: update travel-family icons

2020-02-06 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75092. mbruchert added a comment. optimize svgs REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27187?vs=75091=75092 BRANCH travel-family REVISION DETAIL https://phabricator.kde.org/D27187 AFFECTED FILES

D27187: update travel-family icons

2020-02-06 Thread Mathis Brüchert
mbruchert created this revision. mbruchert added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH travel-family REVISION DETAIL