dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kdeplatformfiledialoghelper.cpp:226
> +//passing non-local files as the working directory is not supported.
> +//See QFileDialogPrivate::initialSelecti
meven accepted this revision.
meven added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kdeplatformfiledialoghelper.cpp:226
> +//passing non-local files as the working directory is not supported.
> +//See QFileDialogPrivate::initialSelections
> +/
ngraham added a comment.
Does this fix https://bugs.kde.org/show_bug.cgi?id=408174?
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D27203
To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir
Cc: ngraham, plasma-devel, Orage, LeG
ngraham added reviewers: meven, ahmadsamir.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D27203
To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
ngraham added a reviewer: dfaure.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D27203
To: apol, #frameworks, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, ragreen, ZrenBo
ngraham added a reviewer: Plasma.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D27203
To: apol, #frameworks, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot,
apol added a comment.
Ping?
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D27203
To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, h
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.
TEST PLAN
Been using it for a few days, no regressions.
Opening sftp:///localhost/.../somefile.text twice, doesn't try