D27238: Add an option to dynamic-break inside words

2020-02-12 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:0a08d45f2b56: Add an option to dynamic-break inside words (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27238?vs=75509&id=75514 REVISION

D27238: Add an option to dynamic-break inside words

2020-02-12 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, happy with that, thanks! REVISION DETAIL https://phabricator.kde.org/D27238 To: eudoxos, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, cent, rrosch, LeGast

D27238: Add an option to dynamic-break inside words

2020-02-11 Thread eudoxos
eudoxos updated this revision to Diff 75509. eudoxos added a comment. Change config key to `dynamic-word-wrap-anywhere` as suggested. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27238?vs=75231&id=75509 REVISION DETAIL https://phabricator.kde.org/D27238 AFFECTED FILES src/dia

D27238: Add an option to dynamic-break inside words

2020-02-11 Thread Christoph Cullmann
cullmann added a comment. Hmm, not sure. Given we have everywhere at the moment the dynamic/static word wrap wording, I would rather stick with that. for me the menu reads "View -> Word Wrap -> Dynamic Word Wrap", too. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator

D27238: Add an option to dynamic-break inside words

2020-02-11 Thread eudoxos
eudoxos added a comment. In D27238#609494 , @cullmann wrote: > I am ok with this. > Thought I would like to have a more consistent name for the config key. > We have already "dynamic-word-wrap", I would like "dynamic-word-wrap-anywhere" bet

D27238: Add an option to dynamic-break inside words

2020-02-11 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I am ok with this. Thought I would like to have a more consistent name for the config key. We have already "dynamic-word-wrap", I would like "dynamic-word-wrap-anywhere" be

D27238: Add an option to dynamic-break inside words

2020-02-11 Thread eudoxos
eudoxos added a comment. A complementary (also related to dynamic wrapping) change is tracked under D27285 . REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27238 To: eudoxos Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks

D27238: Add an option to dynamic-break inside words

2020-02-09 Thread Dominik Haumann
dhaumann added subscribers: cullmann, dhaumann. dhaumann added a comment. I think this patch looks good. @cullmann: this originates from https://www.reddit.com/r/kde/comments/ey4158/comment/fgoycn4?context=3 Any opinion? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricat

D27238: Add an option to dynamic-break inside words

2020-02-08 Thread eudoxos
eudoxos created this revision. eudoxos added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. eudoxos requested review of this revision. REVISION SUMMARY Add option to break lines longer than view width (or static boun