This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:e369e43b807e: Make kstatusnotifieritem available without
dbus (authored by vonreth).
REPOSITORY
R289 KNotifications
jjazeix added a comment.
Can we push it as this to fix the Windows builds? It also breaks a few ones
in https://binary-factory.kde.org/view/Windows%2064-bit/
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D27355
To: vonreth, bcooksley, jjazeix, broulik
Cc:
bcooksley added a comment.
Have you had a chance to look into this @broulik?
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D27355
To: vonreth, bcooksley, jjazeix, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
jjazeix added a reviewer: broulik.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D27355
To: vonreth, bcooksley, jjazeix, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
jjazeix added a comment.
thank you!
I did the same but way worse.
I think we can at least push this fix to remove all failing jobs then clean
it up?
INLINE COMMENTS
> CMakeLists.txt:94
> if (NOT WIN32 AND NOT ANDROID)
> find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus)
bcooksley added inline comments.
INLINE COMMENTS
> kstatusnotifieritem.cpp:48
> +
> +#include
> #include
New header?
> kstatusnotifieritem.cpp:617
> void KStatusNotifierItem::showMessage(const QString , const QString
> , const QString , int timeout)
> {
> #ifdef Q_OS_MACOS
Won't this
vonreth added a comment.
While preparing this I discovered that we should also review the locations
where if MAC is used, as thats not the only platform that should use the
systray icon
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D27355
To: vonreth,
vonreth retitled this revision from "Make kstatusnotifieritem available without
dbus" to "POC: Make kstatusnotifieritem available without dbus".
vonreth edited the summary of this revision.
vonreth added reviewers: bcooksley, jjazeix.
REPOSITORY
R289 KNotifications
REVISION DETAIL
