D27357: Fix infinite recursion in xscreensaver plugin

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R274:3dae871e6b89: Fix infinite recursion in xscreensaver 
plugin (authored by alnikiforov, committed by broulik).

REPOSITORY
  R274 KIdleTime

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27357?vs=75583=77251

REVISION DETAIL
  https://phabricator.kde.org/D27357

AFFECTED FILES
  src/plugins/xscreensaver/xscreensaverbasedpoller.cpp

To: alnikiforov, davidedmundson, broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27357: Fix infinite recursion in xscreensaver plugin

[Kai Uwe Broulik]

broulik added a comment.


  Sorry, I just returned from vacation. I'll merge this on Monday (since 
Frameworks tagging is tomorrow) so we'll get another month worth of testing.

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D27357

To: alnikiforov, davidedmundson, broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27357: Fix infinite recursion in xscreensaver plugin

[Aleksei Nikiforov]

alnikiforov added a comment.


  Could you please merge this change?  Or is something stopping from merging it?

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D27357

To: alnikiforov, davidedmundson, broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27357: Fix infinite recursion in xscreensaver plugin

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D27357

To: alnikiforov, davidedmundson, broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27357: Fix infinite recursion in xscreensaver plugin

[Kai Uwe Broulik]

broulik added a reviewer: Frameworks.

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D27357

To: alnikiforov, davidedmundson, broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27357: Fix infinite recursion in xscreensaver plugin

[Aleksei Nikiforov]

alnikiforov added a comment.


  In D27357#610605 , @broulik wrote:
  
  > Neither the XSync nor the windows backend explicitly call 
`resumingFromIdle` in `simulateUserActivity`, so I think this should be fine.
  >  However, I don't know if that won't indirectly trigger it if the session 
was idle? Maybe we need to check if the session was idle and only then emit the 
signal.
  
  
  I'm not sure how exactly it works, but if session was idle, wouldn't function 
`screensaverActivated` be called on changing state? And it contains `emit 
resumingFromIdle()`:
  
  
https://phabricator.kde.org/source/kidletime/browse/master/src/plugins/xscreensaver/xscreensaverbasedpoller.cpp$37

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D27357

To: alnikiforov, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27357: Fix infinite recursion in xscreensaver plugin

[Kai Uwe Broulik]

broulik added a comment.


  Neither the XSync nor the windows backend explicitly call `resumingFromIdle` 
in `simulateUserActivity`, so I think this should be fine.
  However, I don't know if that won't indirectly trigger it if the session was 
idle? Maybe we need to check if the session was idle and only then emit the 
signal.

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D27357

To: alnikiforov, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27357: Fix infinite recursion in xscreensaver plugin

[Aleksei Nikiforov]

alnikiforov created this revision.
alnikiforov added reviewers: davidedmundson, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alnikiforov requested review of this revision.

REVISION SUMMARY
  Follow up for D27279 
  
  Related to: D17874 

TEST PLAN
  Test plan similar to D27279 , but 
powerdevil should no longer crash

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D27357

AFFECTED FILES
  src/plugins/xscreensaver/xscreensaverbasedpoller.cpp

To: alnikiforov, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns